Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 5, 2022

We do not lint the fixtures code so eslint-disable comments are
superfluous.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 5, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott merged commit fa05f80 into nodejs:master Feb 6, 2022
@Trott
Copy link
Member Author

Trott commented Feb 6, 2022

Landed in fa05f80

@Trott Trott deleted the fixtures-eslint branch February 6, 2022 16:27
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants