doc: clarify v4.2.3 notable items #4155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include reference to CVE-2015-8027 * Fix "socket may no longer have a socket" reference * Expand on non-existent parser causing the error * Soften language for CVE-2015-3193 as impact may not be as great as expected * Clarify that CVE-2015-3194 affects TLS servers using _client certificate authentication_ * Include reference to CVE-2015-6764 * Remove links to nodejs/node-private in commits list
Member
There was a problem hiding this comment.
I speculate that attempts trigger -> attempts to trigger
(sorry If I'm wrong)
Contributor
|
LGTM with the same comment. |
Member
|
LGTM |
rvagg
added a commit
that referenced
this pull request
Dec 5, 2015
* Include reference to CVE-2015-8027 * Fix "socket may no longer have a socket" reference * Expand on non-existent parser causing the error * Soften language for CVE-2015-3193 as impact may not be as great as expected * Clarify that CVE-2015-3194 affects TLS servers using _client certificate authentication_ * Include reference to CVE-2015-6764 * Remove links to nodejs/node-private in commits list PR-URL: #4155 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Author
|
thanks, fixed and landed @ b7a22d4 |
Closed
rvagg
added a commit
that referenced
this pull request
Dec 17, 2015
* Include reference to CVE-2015-8027 * Fix "socket may no longer have a socket" reference * Expand on non-existent parser causing the error * Soften language for CVE-2015-3193 as impact may not be as great as expected * Clarify that CVE-2015-3194 affects TLS servers using _client certificate authentication_ * Include reference to CVE-2015-6764 * Remove links to nodejs/node-private in commits list PR-URL: #4155 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
added a commit
that referenced
this pull request
Dec 23, 2015
* Include reference to CVE-2015-8027 * Fix "socket may no longer have a socket" reference * Expand on non-existent parser causing the error * Soften language for CVE-2015-3193 as impact may not be as great as expected * Clarify that CVE-2015-3194 affects TLS servers using _client certificate authentication_ * Include reference to CVE-2015-6764 * Remove links to nodejs/node-private in commits list PR-URL: #4155 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected
certificate authentication