Skip to content

src: skip costly pushing/popping if we pass zeroes as async context #41279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

src: skip costly pushing/popping if we pass zeroes as async context #41279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16544c4
src: skip costly pushing/popping if we pass zeroes as async context
uNetworkingAB Dec 22, 2021
89afce7
fixup
ronag Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/api/callback.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ InternalCallbackScope::InternalCallbackScope(Environment* env,
CHECK_NOT_NULL(env);
env->PushAsyncCallbackScope();

// Skip costly pushing/popping if we pass zeroes as async context
if (async_context_.async_id == 0) {
pushed_ids_ = false;
return;
}

if (!env->can_call_into_js()) {
failed_ = true;
return;
Expand All @@ -74,10 +80,10 @@ InternalCallbackScope::InternalCallbackScope(Environment* env,

pushed_ids_ = true;

if (asyncContext.async_id != 0 && !skip_hooks_) {
if (!skip_hooks_) {
// No need to check a return value because the application will exit if
// an exception occurs.
AsyncWrap::EmitBefore(env, asyncContext.async_id);
AsyncWrap::EmitBefore(env, async_context_.async_id);
}
}

Expand Down