Skip to content

domain: rename var to let and const #30312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

domain: rename var to let and const #30312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ Domain.prototype.members = undefined;

// Called by process._fatalException in case an error was thrown.
Domain.prototype._errorHandler = function(er) {
var caught = false;
let caught = false;

if ((typeof er === 'object' && er !== null) || typeof er === 'function') {
Object.defineProperty(er, 'domain', {
Expand Down Expand Up @@ -327,7 +327,7 @@ Domain.prototype.add = function(ee) {
// e.add(d);
// e.emit('error', er); // RangeError, stack overflow!
if (this.domain && (ee instanceof Domain)) {
for (var d = this.domain; d; d = d.domain) {
for (let d = this.domain; d; d = d.domain) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please change from var to let in the comments on lines 324 and 325

if (ee === d) return;
}
}
Expand All @@ -351,14 +351,14 @@ Domain.prototype.remove = function(ee) {


Domain.prototype.run = function(fn) {
var ret;
let ret;

this.enter();
if (arguments.length >= 2) {
var len = arguments.length;
var args = new Array(len - 1);
const len = arguments.length;
const args = new Array(len - 1);

for (var i = 1; i < len; i++)
for (let i = 1; i < len; i++)
args[i - 1] = arguments[i];

ret = fn.apply(this, args);
Expand All @@ -373,7 +373,7 @@ Domain.prototype.run = function(fn) {

function intercepted(_this, self, cb, fnargs) {
if (fnargs[0] && fnargs[0] instanceof Error) {
var er = fnargs[0];
const er = fnargs[0];
er.domainBound = cb;
er.domainThrown = false;
Object.defineProperty(er, 'domain', {
Expand All @@ -387,11 +387,11 @@ function intercepted(_this, self, cb, fnargs) {
}

const args = [];
var i, ret;
let ret;

self.enter();
if (fnargs.length > 1) {
for (i = 1; i < fnargs.length; i++)
for (let i = 1; i < fnargs.length; i++)
args.push(fnargs[i]);
ret = cb.apply(_this, args);
} else {
Expand All @@ -415,7 +415,7 @@ Domain.prototype.intercept = function(cb) {


function bound(_this, self, cb, fnargs) {
var ret;
let ret;

self.enter();
if (fnargs.length > 0)
Expand Down