-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
test: add test-spawn-cmd-named-pipe #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test-spawn-cmd-named-pipe #2770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this section.
|
Thanks @cjihrig for all the feedback! I will revamp this test according to your suggestions. Can the Copyright notice really be removed? I don't think so. Even with a permissive license, one of the clauses is to preserve the copyright notice. |
|
Yea, the copyright in all the files was removed a long time ago in io.js. I'm not a lawyer, but I think I remember something about only needing the license in the root of the project. |
|
Ok, I'll take your word for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the format as in #2109
0e0886b to
e9003b2
Compare
|
Updated. PTAL. |
|
The commented out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Const
e9003b2 to
46e1d9f
Compare
|
Updated according to feedback. Thanks again for all the help! Much more slick now 👍 CI run: https://ci.nodejs.org/job/node-test-pull-request/333/ |
|
argh.. linter errors |
Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: nodejs/node-v0.x-archive#7345
46e1d9f to
ab7d0b8
Compare
|
Fixed whitespace. One more try: https://ci.nodejs.org/job/node-test-pull-request/334/ |
Adding a Windows test to verify that a node process spawned via
cmd with named pipes can access its stdio streams.
Ref: nodejs/node-v0.x-archive#7345
This test was orphaned in joyent/node:master. It is still useful.