Skip to content

test:favor arrow function in callback #24542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test:favor arrow function in callback #24542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151e140
test:favor arrow function in callback
kotAPI Nov 21, 2018
389c79a
lint: space is required before arrow to pass lint test
kotAPI Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-zlib-close-after-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
const common = require('../common');
const zlib = require('zlib');

zlib.gzip('hello', common.mustCall(function(err, out) {
zlib.gzip('hello', common.mustCall((err, out)=> {
Copy link
Contributor

@sreepurnajasti sreepurnajasti Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space is required before arrow to pass the lint test
https://travis-ci.com/nodejs/node/jobs/159977196

Copy link
Contributor Author

@kotAPI kotAPI Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that, I've pushed again with the required changes, thanks!

const unzip = zlib.createGunzip();
unzip.write(out);
unzip.close(common.mustCall());
Expand Down