- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
doc: remove recommendation to use node-eps #23148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    https://github.com/nodejs/node-eps has been archived and new proposals can no longer be opened there. Remove the corresponding recommendation to use it. Refs: nodejs/TSC#335
| I know we archived nodejs/node-eps, but maybe we can find some words to put in its stead. Maybe  | 
              
                    Trott
  
              
              approved these changes
              
                  
                    Sep 28, 2018 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Sep 28, 2018 
                  
              
              
            
            
              
                    devsnek
  
              
              approved these changes
              
                  
                    Sep 28, 2018 
                  
              
              
            
            
              
                    jasnell
  
              
              approved these changes
              
                  
                    Sep 28, 2018 
                  
              
              
            
            
              
                    addaleax
  
              
              approved these changes
              
                  
                    Sep 29, 2018 
                  
              
              
            
            
              
                    trivikr
  
              
              approved these changes
              
                  
                    Sep 29, 2018 
                  
              
              
            
            
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Sep 29, 2018 
                  
              
              
            
            
              
                    thefourtheye
  
              
              approved these changes
              
                  
                    Sep 29, 2018 
                  
              
              
            
            
| Landed in 9b34dfe. | 
    
  danbev 
      pushed a commit
      that referenced
      this pull request
    
      Oct 2, 2018 
    
    
      
  
    
      
    
  
https://github.com/nodejs/node-eps has been archived and new proposals can no longer be opened there. Remove the corresponding recommendation to use it. PR-URL: #23148 Refs: nodejs/TSC#335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Oct 3, 2018 
    
    
      
  
    
      
    
  
https://github.com/nodejs/node-eps has been archived and new proposals can no longer be opened there. Remove the corresponding recommendation to use it. PR-URL: #23148 Refs: nodejs/TSC#335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  This was referenced Oct 10, 2018 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
https://github.com/nodejs/node-eps has been archived and new proposals
can no longer be opened there. Remove the corresponding recommendation
to use it.
Refs: nodejs/TSC#335
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes