Skip to content

url: use foreach-style C++ loop #23138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

url: use foreach-style C++ loop #23138

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcad6b4
url: use foreach-style C++ loop
tniessen Sep 27, 2018
2440d9c
fixup! url: use foreach-style C++ loop
tniessen Sep 28, 2018
b0eb933
fixup! url: use foreach-style C++ loop
tniessen Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/node_url.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,8 @@ class URL {

std::string path() const {
std::string ret;
for (auto i = context_.path.begin(); i != context_.path.end(); i++) {
ret += '/';
ret += *i;
for (const std::string& i : context_.path) {
Copy link
Member

@targos targos Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename it to something like path_element?
To me, i means "index" and that's how it's always used in JS.

ret += '/' + i;
}
return ret;
}
Expand Down