errors: fix ERR_SOCKET_BAD_PORT message #23015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current message says 'Port should be > 0' meaning '0' is an invalid value. You can pass '0' to get a random port from the system. The correct message for this error is 'Port should be >= 0'.
nodejs-github-bot
added
the
errors
addaleax
approved these changes
Sep 22, 2018
joyeecheung
approved these changes
Sep 22, 2018
|
Windows rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20940/ ✔️ |
rvagg
approved these changes
Sep 22, 2018
cjihrig
approved these changes
Sep 22, 2018
jasnell
approved these changes
Sep 22, 2018
Trott
added
the
author ready
BridgeAR
approved these changes
Sep 23, 2018
trivikr
approved these changes
Sep 25, 2018
|
Landed in 4e084ad |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Sep 25, 2018
The current message says 'Port should be > 0' meaning '0' is an invalid value. You can pass '0' to get a random port from the system. The correct message for this error is 'Port should be >= 0'. PR-URL: #23015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
The current message says 'Port should be > 0' meaning '0' is an invalid value. You can pass '0' to get a random port from the system. The correct message for this error is 'Port should be >= 0'. PR-URL: #23015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message says 'Port should be > 0' meaning '0' is an invalid value. You can pass '0' to get a random port from the system. The correct message for this error is 'Port should be >= 0'.
A correct message for this type of error is being shown in the docs already: https://nodejs.org/api/errors.html#errors_class_rangeerror
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes