Skip to content

doc: add callback parameters of terminate in worker_threads #23002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add callback parameters of terminate in worker_threads #23002

wants to merge 1 commit into from

Conversation

SerayaEryn
Copy link
Contributor

Adds parameters for the callback of worker.terminate().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 21, 2018
addaleax
addaleax approved these changes Sep 21, 2018
View reviewed changes
@danbev
Copy link
Contributor

danbev commented Sep 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17400/

@vsemozhetbyt
Copy link
Contributor

Landed in ab6ddc0
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Sep 24, 2018
@SerayaEryn @vsemozhetbyt
doc: add callback parameters of worker.terminate()
ab6ddc0 
PR-URL: #23002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Sep 25, 2018
@SerayaEryn @targos
doc: add callback parameters of worker.terminate()
24073ce 
PR-URL: #23002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@mscdex mscdex mscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@SerayaEryn @danbev @vsemozhetbyt @mscdex @jasnell @Trott @addaleax @cjihrig @BridgeAR @nodejs-github-bot