build,win: remove unmatched endlocal statement
#22627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
refack
requested review from
addaleax,
bzoz and
joaocgreis
and removed request for
addaleax
|
/CC @nodejs/platform-windows @nodejs/build-files |
2 tasks
addaleax
approved these changes
Aug 31, 2018
refack
force-pushed
the
remove-vcbuild-orphen
branch
from
06d2f64 to
0ec9036
Compare
refack
changed the title
endlocal statement
refack
force-pushed
the
remove-vcbuild-orphen
branch
from
0ec9036 to
48edf2b
Compare
Fixed. |
richardlau
approved these changes
Aug 31, 2018
cjihrig
approved these changes
Aug 31, 2018
BridgeAR
approved these changes
Sep 1, 2018
BridgeAR
added
author ready
bzoz
approved these changes
Sep 3, 2018
trivikr
approved these changes
Sep 4, 2018
Seems like it's a leftover from c403eeb PR-URL: nodejs#22627 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
refack
force-pushed
the
remove-vcbuild-orphen
branch
from
48edf2b to
4cea01a
Compare
|
landed in 4cea01a |
targos
pushed a commit
that referenced
this pull request
Sep 5, 2018
Seems like it's a leftover from c403eeb PR-URL: #22627 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Seems like it's a leftover from c403eeb PR-URL: #22627 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it's a leftover from c403eeb
Refs: #22582 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes