test: fix typo in test name #22605
Closed
test: fix typo in test name #22605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct test name to reflect the module it tests (`trace_events`).
|
👍 this comment to approve fast-tracking. |
richardlau
approved these changes
Aug 30, 2018
lpinca
approved these changes
Aug 30, 2018
cjihrig
approved these changes
Aug 30, 2018
|
Landed in 366ffdc |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 30, 2018
Correct test name to reflect the module it tests (`trace_events`). PR-URL: nodejs#22605 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Correct test name to reflect the module it tests (`trace_events`). PR-URL: #22605 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Correct test name to reflect the module it tests (`trace_events`). PR-URL: #22605 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Correct test name to reflect the module it tests (`trace_events`). PR-URL: #22605 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct test name to reflect the module it tests (
trace_events).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes