-
-
Couldn't load subscription status.
- Fork 33.6k
src: implement query callbacks for vm #22390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5878,6 +5878,26 @@ enum class PropertyHandlerFlags { | |
| }; | ||
|
|
||
| struct NamedPropertyHandlerConfiguration { | ||
| NamedPropertyHandlerConfiguration( | ||
| GenericNamedPropertyGetterCallback getter, | ||
| GenericNamedPropertySetterCallback setter, | ||
| GenericNamedPropertyQueryCallback query, | ||
| GenericNamedPropertyDeleterCallback deleter, | ||
| GenericNamedPropertyEnumeratorCallback enumerator, | ||
| GenericNamedPropertyDefinerCallback definer, | ||
| GenericNamedPropertyDescriptorCallback descriptor, | ||
| Local<Value> data = Local<Value>(), | ||
| PropertyHandlerFlags flags = PropertyHandlerFlags::kNone) | ||
| : getter(getter), | ||
| setter(setter), | ||
| query(query), | ||
| deleter(deleter), | ||
| enumerator(enumerator), | ||
| definer(definer), | ||
| descriptor(descriptor), | ||
| data(data), | ||
| flags(flags) {} | ||
|
|
||
| NamedPropertyHandlerConfiguration( | ||
| /** Note: getter is required */ | ||
| GenericNamedPropertyGetterCallback getter = 0, | ||
|
|
@@ -5929,6 +5949,25 @@ struct NamedPropertyHandlerConfiguration { | |
|
|
||
|
|
||
| struct IndexedPropertyHandlerConfiguration { | ||
| IndexedPropertyHandlerConfiguration( | ||
| IndexedPropertyGetterCallback getter, | ||
| IndexedPropertySetterCallback setter, IndexedPropertyQueryCallback query, | ||
| IndexedPropertyDeleterCallback deleter, | ||
| IndexedPropertyEnumeratorCallback enumerator, | ||
| IndexedPropertyDefinerCallback definer, | ||
| IndexedPropertyDescriptorCallback descriptor, | ||
| Local<Value> data = Local<Value>(), | ||
| PropertyHandlerFlags flags = PropertyHandlerFlags::kNone) | ||
| : getter(getter), | ||
| setter(setter), | ||
| query(query), | ||
| deleter(deleter), | ||
| enumerator(enumerator), | ||
| definer(definer), | ||
| descriptor(descriptor), | ||
| data(data), | ||
| flags(flags) {} | ||
|
|
||
| IndexedPropertyHandlerConfiguration( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @TimothyGu I noticed in the linked to issues in the opening summary that V8 work was needed. A patch for V8 was merged but then reverted for perf reasons. Was the perf issue eventually resolved and the appropriate V8 changed landed or is this PR working around V8? |
||
| /** Note: getter is required */ | ||
| IndexedPropertyGetterCallback getter = 0, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimothyGu As someone not super familiar with the internals of this (me) can you explain a bit about how this is fixing the linked to issues.