Skip to content

Conversation

@vitpavlenko
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
    replaced var with let or const but saved var in for

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 19, 2018
@devsnek
Copy link
Member

devsnek commented Mar 19, 2018

thanks for the pr! however, we don't merge changes like this. as parts of the project are refactored they get upgraded. this pr would mess up our git blame and history

@tniessen
Copy link
Member

Ref #13756

@TimothyGu
Copy link
Member

As mentioned by other people, we would like to not do changes like this en masse. Thank you for your contribution though, and I encourage you to take a look at our other issues :)

@TimothyGu TimothyGu closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants