Skip to content

Conversation

@Fishrock123
Copy link
Contributor

See #1549, these files are produced while running make test-npm.

R=@othiym23

@Fishrock123 Fishrock123 added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 30, 2015
@othiym23
Copy link
Contributor

othiym23 commented May 1, 2015

This could be landed, but I think a better solution would be to fix the relevant test(s) in npm to not treat fixtures as mutable, and to update the test-npm stanza in the io.js Makefile to clean up the .bin directory after running the tests. .bin doesn't need to be included for distribution (which is part of why the release tarball doesn't include it). Rather than clutter the build tree, we should keep working on this until the test suite is idempotent.

@Fishrock123
Copy link
Contributor Author

Ok, doing that. some make test-npm cleanup is at #1576, and I'll look into fixing that test from npm.

@Fishrock123 Fishrock123 closed this May 1, 2015
@Fishrock123 Fishrock123 deleted the gitignore-npm-artifacts branch May 12, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants