child_process: use internal/errors #14009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
tniessen
added
the
errors
refack
approved these changes
Jun 30, 2017
80 tasks
jasnell
approved these changes
Jun 30, 2017
Trott
added
the
semver-major
lpinca
reviewed
Jul 1, 2017
lib/internal/child_process.js
Outdated
| @@ -545,7 +551,8 @@ function setupChannel(target, channel) { | |||
| options = undefined; | |||
| } else if (options !== undefined && | |||
| (options === null || typeof options !== 'object')) { | |||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object'); | |||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object', | |||
There was a problem hiding this comment.
Why is 'Object' capitalized here?
There was a problem hiding this comment.
It was like that before, should I change it?
There was a problem hiding this comment.
Yeah I noticed but few lines above (260) it is in lowercase. I'd make them consistent.
|
@nodejs/ctc due to semverity |
lpinca
approved these changes
Jul 2, 2017
targos
approved these changes
Jul 3, 2017
tniessen
added a commit
that referenced
this pull request
Jul 3, 2017
PR-URL: #14009 Refs: #11273 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in fe730d3. CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7044/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
child_process