doc: require uses fs root for '/' prefix #11897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
doc
nodejs-github-bot
added
doc
PR-URL: nodejs#11897 Fixes: nodejs#7151
jasnell
approved these changes
Mar 17, 2017
cjihrig
approved these changes
Mar 17, 2017
| 2. If X begins with './' or '/' or '../' | ||
| 2. If X begins with '/' | ||
| a. set Y to be the filesystem root | ||
| 3. If X begins with './' or '/' or '../' |
There was a problem hiding this comment.
Should it be just 'If X begins with './' or '../'' now?
There was a problem hiding this comment.
No, since we still want to do 3.a. and 3.b. even if 2. is taken
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2017
PR-URL: #11897 Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 757ff80 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
PR-URL: #11897 Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
PR-URL: #11897 Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #11897 Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#11897 Fixes: nodejs/node#7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7151
Checklist
Affected core subsystem(s)
doc