src: drop the NODE_ISOLATE_SLOT macro #11692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Mar 5, 2017
cjihrig
approved these changes
Mar 6, 2017
jasnell
approved these changes
Mar 6, 2017
fhinkel
approved these changes
Mar 9, 2017
|
Thanks, landed in 6d16048. |
fhinkel
pushed a commit
that referenced
this pull request
Mar 9, 2017
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453. PR-URL: #11692 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453. PR-URL: nodejs#11692 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453. PR-URL: nodejs#11692 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
|
doesn't look like this should be backported. lmk if I'm wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NODE_ISOLATE_SLOTmacro has been unused since c3cd453.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src
CI: https://ci.nodejs.org/job/node-test-commit/8269/