Skip to content

aix: fix os.release() #10245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

aix: fix os.release() #10245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cc9ed2
aix: fix os.release()
jBarz Dec 13, 2016
f8238fb
use snprintf
jBarz Dec 13, 2016
4eba54c
add test for os.release() on aix
jBarz Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/node_os.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,13 @@ static void GetOSRelease(const FunctionCallbackInfo<Value>& args) {
if (uname(&info) < 0) {
return env->ThrowErrnoException(errno, "uname");
}
# ifdef _AIX
char release[256];
sprintf(release, "%s.%s", info.version, info.release);
Copy link
Member

@richardlau richardlau Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use snprintf for consistency with the rest of this file?

rval = release;
# else
rval = info.release;
# endif
#else // Windows
char release[256];
OSVERSIONINFOW info;
Expand Down