Skip to content

Test: stdio.js SIGWINCH test coverage #10063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Test: stdio.js SIGWINCH test coverage #10063

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f4f91b
add test coverage for SIGWINCH in stdio.js
sarahmeyer Dec 1, 2016
1fb5d71
test: adding test coverage for SIGWINCH in stdio.js, call original fu…
sarahmeyer Dec 1, 2016
04fb7e1
squash: adding exception for EINVAL on SmartOS
Trott Dec 26, 2016
d4cafa0
squash: comment explaining the console.log()
Trott Dec 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions test/pseudo-tty/test-stderr-stdout-handle-sigwinch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
'use strict';
const common = require('../common');

// if printing, add to out file
const originalRefreshSizeWrapperStderr = process.stderr._refreshSize;
const originalRefreshSizeWrapperStdout = process.stdout._refreshSize;

const refreshSizeWrapperStderr = () => {
console.log('calling stderr._refreshSize');
try {
originalRefreshSizeWrapperStderr.call(process.stderr);
} catch (e) {
// EINVAL happens on SmartOS if emulation is incomplete
if (!common.isSunOS || e.code !== 'EINVAL')
throw e;
}
};

const refreshSizeWrapperStdout = () => {
console.log('calling stdout._refreshSize');
Copy link
Member

@jasnell jasnell Dec 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment indicating that the console.log is part of the test would be helpful.

Copy link
Member

@Trott Trott Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done. Will run Ci again because there was some refactoring that accompanied it.

try {
originalRefreshSizeWrapperStdout.call(process.stdout);
} catch (e) {
// EINVAL happens on SmartOS if emulation is incomplete
if (!common.isSunOS || e.code !== 'EINVAL')
throw e;
}
};

process.stderr._refreshSize = refreshSizeWrapperStderr;
process.stdout._refreshSize = refreshSizeWrapperStdout;

process.emit('SIGWINCH');
2 changes: 2 additions & 0 deletions test/pseudo-tty/test-stderr-stdout-handle-sigwinch.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
calling stdout._refreshSize
calling stderr._refreshSize