Skip to content

url, test: add inspect to TupleOrigin #10039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

url, test: add inspect to TupleOrigin #10039

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6b324e
url: add inspect function to TupleOrigin
captainsafia Dec 1, 2016
b930653
test: add test for inspect in TupleOrigin
captainsafia Dec 1, 2016
d2a35cb
url: fix spacing in inspect string
captainsafia Dec 2, 2016
79a9b53
test: update tests to match new format
captainsafia Dec 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,15 @@ class TupleOrigin {
result += `:${this.port}`;
return result;
}

inspect() {
return `TupleOrigin{
Copy link
Member

@addaleax addaleax Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have spaces before the { in most cases here?

scheme: ${this.scheme},
host: ${this.host},
port: ${this.port},
domain: ${this.domain}
}`;
}
}

class URL {
Expand Down
37 changes: 37 additions & 0 deletions test/parallel/test-util-inspect-tuple-origin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
'use strict';

require('../common');
const assert = require('assert');
const inspect = require('util').inspect;
const URL = require('url').URL;

assert.strictEqual(
inspect(URL.originFor('http://test.com:8000')),
`TupleOrigin{
scheme: http,
host: test.com,
port: 8000,
domain: null
}`
);

assert.strictEqual(
inspect(URL.originFor('http://test.com')),
`TupleOrigin{
scheme: http,
host: test.com,
port: undefined,
domain: null
}`
);


assert.strictEqual(
inspect(URL.originFor('https://test.com')),
`TupleOrigin{
scheme: https,
host: test.com,
port: undefined,
domain: null
}`
);