Node.js 10.1.0 build broken on ppc64[le] #20642
Description
- Version: 10.1.0
- Platform: Fedora Linux
- Subsystem: Build system
Attempting to build 10.1.0 on ppc64 and ppc64le architectures results in a build failure. This failure was not present on 10.0.0.
My guess is that one of the assembler changes that came in between v8 6.6.346.27 and 6.6.346.24 broke something.
In file included from ../deps/v8/src/base/base-export.h:8:0,
from ../deps/v8/src/base/bits.h:11,
from ../deps/v8/src/ppc/macro-assembler-ppc.cc:10:
../deps/v8/src/ppc/macro-assembler-ppc.cc: In member function 'void v8::internal::TurboAssembler::Prologue()':
../deps/v8/src/ppc/macro-assembler-ppc.cc:853:15: error: expected primary-expression before '!=' token
DCHECK(base != no_reg);
^
../deps/v8/include/v8config.h:346:54: note: in definition of macro 'V8_UNLIKELY'
# define V8_UNLIKELY(condition) (__builtin_expect(!!(condition), 0))
^~~~~~~~~
../deps/v8/src/base/logging.h:63:27: note: in expansion of macro 'DCHECK_WITH_MSG'
#define DCHECK(condition) DCHECK_WITH_MSG(condition, #condition)
^~~~~~~~~~~~~~~
../deps/v8/src/ppc/macro-assembler-ppc.cc:853:3: note: in expansion of macro 'DCHECK'
DCHECK(base != no_reg);
^~~~~~