This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Support options that is classes with props #25454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs/node@7180597 35f7deb#commitcomment-11406521
|
Should this have been PR'd to nodejs/io.js? |
Author
|
I think in both, same issue with current version of node |
|
I think you can just replace the |
Author
|
done |
lib/_http_client.js
Outdated
There was a problem hiding this comment.
style: space between operands, options || {}
Member
|
Closing this here in favor of the corresponding nodejs/node PR. This won't be able to land here. If the PR lands in nodejs/node, we can cherry pick back to v0.12 if appropriate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node@7180597
35f7deb#commitcomment-11406521