Skip to content
This repository was archived by the owner on Aug 1, 2019. It is now read-only.

Conversation

@Gioyik
Copy link
Contributor

@Gioyik Gioyik commented Apr 17, 2015

CC #55

@c0b41
Copy link

c0b41 commented Apr 17, 2015

@Gioyik When will the merge?

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 17, 2015

@ayhankuru Let's wait for more people review it, then someone with the rights will merge it. :)

@rosskukulinski
Copy link
Contributor

Overall looks good -- thanks for pulling this together @Gioyik. I'm wondering how we should reference the pending 1.8 release (ongoing here including draft release notes). We are including the 1.8 perf improvements, but if its not out yet, then I think we should bundle that comment with the actual 1.8 release notes.

I'm thinking that we shouldn't wait for 1.8 to land for us to release this weekly update. In that case, lets hold onto the 1.8 crypto performance comment until next week.

Thoughts?

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 18, 2015

I think is OK in the way we present it. It's on Comunity Updates section and not presented as something released. But we can keep it for a week update when we mention 1.8 features. I don't have problem with it.

@diagramatics
Copy link
Contributor

I wonder, should we use H3 for Notable Changes and Known Issues or H4? I found the rendered Markdown, when pasted to Medium automatically formats it right like the rest of the published articles with H4.

And speaking of Known Issues, none for this week?

This comment was marked as off-topic.

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 19, 2015

And speaking of Known Issues, none for this week?

Not this time: https://github.com/iojs/io.js/blob/v1.x/CHANGELOG.md#2015-04-14-version-171-rvagg

@diagramatics
Copy link
Contributor

Hm, weird. 1.8.0 has the same issues as 1.6.4. Is it intentional?

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 19, 2015

@diagramatics not sure about it, but seems something to be discussed for next weekly update due this week is about 1.7.x

@yosuke-furukawa
Copy link
Member

I guess Known Issues is just forgotten ...
We have to include the Known issues in this article. I will fix the change log and throw a pull request to io.js.

If we remove them, everyone misleads the known issues are resolved.

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 21, 2015

@yosuke-furukawa which know issues we should add? Same as in previous weekly update?

@yosuke-furukawa
Copy link
Member

@Gioyik
Here. nodejs/node#1473
The known issues are seems to be good. But does not merge yet.
io.js core collaborators is discussing on how to handle the Known issues.

@Gioyik go ahead to write down the Known issues and publish the medium ??? this is Wednesday!!!

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 22, 2015

@yosuke-furukawa know issues are added. Let me know if there's something to add.

@yosuke-furukawa
Copy link
Member

LGTM.

yosuke-furukawa added a commit that referenced this pull request Apr 22, 2015
Create weekly-update.2015-04-17.md
@yosuke-furukawa yosuke-furukawa merged commit d34ba71 into nodejs:master Apr 22, 2015
@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 22, 2015

I have not permissions to merge PR (I am not added to org) and publish on Medium. So from now it's a task of someone else :)

@yosuke-furukawa
Copy link
Member

I don't have a permission to publish on Medium neither. @julianduque @mikeal please publish our weekly updates on medium :)

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 22, 2015

Show us your super powers \o/

@julianduque
Copy link
Contributor

Published: https://medium.com/node-js-javascript/io-js-week-of-april-17th-e4c6f2db7659

Sorry for the late publication

@diagramatics
Copy link
Contributor

@julianduque No subtitles for this week on Medium?

(I feel bad for nitpicking all over the place)

@julianduque
Copy link
Contributor

@diagramatics you are the official nit picker ;) and done, added subtitles

@diagramatics
Copy link
Contributor

Great, thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants