Skip to content

fix: handle prereleases #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021
Merged

fix: handle prereleases #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sources/Engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import semver from 'semver';

import defaultConfig from '../config.json';

import * as semverUtils from './semverUtils'
import * as folderUtils from './folderUtils';
import * as pmmUtils from './pmmUtils';
import {SupportedPackageManagers, SupportedPackageManagerSet} from './types';
Expand Down Expand Up @@ -90,7 +91,7 @@ export class Engine {
throw new UsageError(`This package manager (${locator.name}) isn't supported by this corepack build`);

const ranges = Object.keys(definition.ranges).reverse();
const range = ranges.find(range => semver.satisfies(locator.reference, range));
const range = ranges.find(range => semverUtils.satisfiesWithPrereleases(locator.reference, range));
if (typeof range === `undefined`)
throw new Error(`Assertion failed: Specified resolution (${locator.reference}) isn't supported by any of ${ranges.join(`, `)}`);

Expand All @@ -116,7 +117,7 @@ export class Engine {
return {name: descriptor.name, reference: cachedVersion};

const candidateRangeDefinitions = Object.keys(definition.ranges).filter(range => {
return semver.intersects(range, descriptor.range);
return semverUtils.satisfiesWithPrereleases(descriptor.range, range)
});

const tagResolutions = await Promise.all(candidateRangeDefinitions.map(async range => {
Expand Down