Skip to content

doc: note that release config is removed after 6m #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

doc: note that release config is removed after 6m #997

merged 1 commit into from
Jan 4, 2018

Conversation

@gibfahn
Copy link
Member

@gibfahn gibfahn commented Nov 13, 2017

Anything stored in GitHub will still be available in the Git history.

Fixes: #926

@gibfahn
doc: note that release config is removed after 6m
46df02e 
Anything stored in GitHub will still be available in the Git history.

Fixes: nodejs#926
@gibfahn gibfahn requested a review from rvagg November 13, 2017 15:40
@gibfahn
Copy link
Member Author

gibfahn commented Nov 13, 2017

cc/ @nodejs/tsc please review (more info at #926).

ofrobots

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

cjihrig

This comment was marked as off-topic.

Sign in to view

@rvagg
Copy link
Member

rvagg commented Nov 13, 2017

love it, thanks @gibfahn, lgtm

rvagg

This comment was marked as off-topic.

Sign in to view

joaocgreis

This comment was marked as off-topic.

Sign in to view

refack

This comment was marked as off-topic.

Sign in to view

mhdawson

This comment was marked as off-topic.

Sign in to view

@mhdawson mhdawson mentioned this pull request Dec 5, 2017
Closed
@rvagg
Copy link
Member

rvagg commented Dec 6, 2017

Agreement in today's TSC meeting on the proviso that we save current config where possible in git. So we should probably do a checkin of config.xmls here first then we can move ahead.

@Trott Trott removed the tsc-agenda label Dec 6, 2017
@rvagg rvagg mentioned this pull request Dec 19, 2017
Closed
@maclover7
Copy link
Contributor

ping @gibfahn

@gibfahn gibfahn merged commit 8849185 into nodejs:master Jan 4, 2018
@gibfahn gibfahn deleted the remove-eol-ci branch January 4, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaocgreis joaocgreis joaocgreis approved these changes

@rvagg rvagg rvagg approved these changes

@mhdawson mhdawson mhdawson approved these changes

+4 more reviewers

@ofrobots ofrobots ofrobots left review comments

@refack refack refack approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rvagg rvagg

@mhdawson mhdawson

Labels

tsc-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gibfahn @rvagg @maclover7 @ofrobots @refack @joaocgreis @MylesBorins @cjihrig @mhdawson @Trott