Skip to content

404 on non existent container path #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

404 on non existent container path #1762

merged 2 commits into from
Nov 5, 2024
+436 −190

Conversation

@bourgeoa
Copy link
Member

@bourgeoa bourgeoa commented Feb 26, 2024

There was already a 404 on non existant filename.
So it is just a code cleaning.

TallTed
TallTed reviewed Feb 26, 2024
View reviewed changes
@bourgeoa bourgeoa requested a review from zg009 March 16, 2024 08:50
zg009
zg009 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@zg009 zg009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works to me, after all it is a very minor change.

@bourgeoa bourgeoa merged commit 417bf13 into main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TallTed TallTed TallTed left review comments

@zg009 zg009 zg009 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bourgeoa @TallTed @zg009