Build production ready docker-image #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
approved these changes
Jan 6, 2020
Member
michielbdejong
left a comment
michielbdejong
left a comment
There was a problem hiding this comment.
Impressive!
Haven't tried it, but looks like Angelo tested it extensively.
Let me know if more users need to be added to https://hub.docker.com/orgs/nodesolidserver (currently it has Angelo, Jackson, Kjetil and me).
Contributor
Author
|
Thanks for merging. How is the process of bringing this to the master branch? The build process only works for master branch (builds lastest npm version) and versioned tags (e.g. 5.2.2) |
Member
|
Good question, I created #1391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the source code and automated test for a production ready docker image of node-solid-server. It is derived (mostly copied) from my work at aveltens/docker-solid-server
All the docker-image related code is in it's own subfolder
docker-imagewith it's own readme and documentation.After merging this PR, the docker hub configuration of nodesolidserver/node-solid-server has to be adjusted to the location of the dockerfile (
docker-image/src/Dockerfile) and automated builds should be configured for the master branch and version tags.Related issue: #1167