Skip to content

Conversation

@Granjow
Copy link

@Granjow Granjow commented Dec 22, 2020

This PR refers to #99.

Please comment on the first draft. Warning: It does not run yet as the port is WIP.

@hrueger
Copy link
Member

hrueger commented Feb 7, 2021

Hi @Granjow ,
Can I help with this PR?

I'd really like to see this getting merged, as I want to add DMX receiving functionality. This will be way easier using TypeScript.

@Granjow
Copy link
Author

Granjow commented Feb 8, 2021

Hi @hrueger , yes, that would be kind. Most important would be a short review of the current TypeScript interface (to see if it makes sense and if it would work for you too) before we start porting the code. If it looks okay from your side, I would then complete the Enttec driver and I'd be very happy about any help in the other drivers and in general!

@hrueger
Copy link
Member

hrueger commented Feb 9, 2021

@Granjow I've sent an email about collaborating to the mail address on your website.

@Cyberuben
Copy link

Is there still any activity on this? I'd love to see this working

@Granjow Granjow changed the title WIP: Port dmx to TypeScript Port dmx to TypeScript May 18, 2021
@Granjow
Copy link
Author

Granjow commented May 18, 2021

From our side the port should be complete! Some drivers are even tested.

Also, Enttec USB Open works now.

Open for review/merge!

@hrueger
Copy link
Member

hrueger commented Jul 15, 2021

@wiedi Any update on this?
I'm using it currently and it works great.

@wiedi
Copy link
Member

wiedi commented Jul 15, 2021

Hi, when this was proposed I thought this was just about adding some type annotations, while the rest would stay compatible.
Now this seems to be a 10k+ line rewrite into a language I don't understand.

I am not able to review this or maintain it.

I understand that a lot of energy went into this and that it seems to be useful. Given that this breaks the API maybe it would make sense to move this into a separate repository? I'd be happy to create a "dmx-ts" or similar thing under the node-dmx organisation and give you admin rights. Would that make sense?

@hrueger
Copy link
Member

hrueger commented Jul 15, 2021

I can totally understand you. I'd be happy with dmx-ts!

@wiedi
Copy link
Member

wiedi commented Jul 15, 2021

Alrighty. I've sent an invite to you @hrueger and @Granjow that should grant admin access to it. With that you should be able to push and then switch the repo public. Let me know if you need anything more.

@hrueger
Copy link
Member

hrueger commented Jul 15, 2021

Thanks a lot. I'll push tomorrow.

@hrueger
Copy link
Member

hrueger commented Jul 16, 2021

@wiedi I'm done. Sorry for the commit history, but I've had a few problems with the spec test which would work on windows but not on linux. Hope it doesn't matter 👍

@Granjow I added / changed a couple of things:

  • spec test now works on Linux
  • setup auto-publishing to npm on git tags (instructions are at the bottom of the readme)
  • fixed the repository urls in the package.json file
  • only pack dist folder and not src into the package
  • run the CI on GitHub Actions instead of Travis CI

@wiedi
Copy link
Member

wiedi commented Jul 16, 2021

Fantastic!

@wiedi wiedi closed this Jul 16, 2021
@Granjow
Copy link
Author

Granjow commented Jul 26, 2021

@wiedi Thanks, could you send the invitation again? Was offline the last few days.

@hrueger Sounds very good, thank you!

Once I have access I can restore the commit history, I'm a bit used to doing such stuff ;)

@wiedi
Copy link
Member

wiedi commented Jul 26, 2021

Sure, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants