Skip to content

Fix mac setup #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2023
Merged

Fix mac setup #461

merged 7 commits into from
May 21, 2023

Conversation

@dyashuni
Copy link
Contributor

@dyashuni dyashuni commented May 10, 2023 •
edited
Loading

  • add macos to CI
  • allow asserts in C++ tests (remove -DNDEBUG)
  • fix checkIntegrity data[j] is always >= 0
  • add checks for compiler flags -march=native and -mcpu=apple-m1 for python installation for macos
  • fix compiler flags for Windows

@dyashuni dyashuni force-pushed the fix_mac_setup branch 6 times, most recently from 8a1f228 to e9850fe Compare May 10, 2023 11:56
@dyashuni
Copy link
Contributor Author

dyashuni commented May 10, 2023

fixes
#318

This was referenced May 10, 2023
Open
Open
@dyashuni dyashuni merged commit a4c8b0b into nmslib:develop May 21, 2023
@yurymalkov yurymalkov mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dyashuni