nix::InterfaceAddress: adding interface information if it is UP. #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
approved these changes
Aug 11, 2024
SteveLauC
reviewed
Aug 11, 2024
Member
SteveLauC
left a comment
SteveLauC
left a comment
There was a problem hiding this comment.
Well, perhaps I need a reason for this change even though it is ok and trivial, we already have this info in addr.flags.contains(InterfaceFlags::IFF_UP).
I think we need to consider what should be stored in the struct, currently, all the stored fields come from the libc struct libc::ifaddrs.
Contributor
Author
|
well, we can consider extra fields as info access aliases/shortcuts wdyt ? |
Member
I am thinking that if getting this info is already straightforward, then there is no need to add a shortcut for it 😶 |
Member
|
CI fixed in #2470 |
Contributor
Author
|
Sure, anyway up to you if you want to merge it, no hard feeling if you don't :) |
Member
|
Thanks for the understanding ❤️, I will close this PR then:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.