-
Notifications
You must be signed in to change notification settings - Fork 718
Add IPV6_PKTINFO, Correct documentationn for IPV6_RECVPKTINFO #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SteveLauC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in contributing to Nix, please rebase your branch so that the CI can work (We have migrated from Cirrus to GitHub Action)
|
Hi, I need to be able to set this sockopt as well - should I make a new PR? This one seems a bit stale cc @SteveLauC |
Hi, thanks for your interest in filing a PR for this! Please go ahead:) |
|
hey @evanrittenhouse, Can I revive this PR instead? will rebase it today |
|
I must be missing some thing. I can not find |
|
BTW, a changelog is needed, please see CONTRIBUTING.md on how to add one. If you apply the changes requested by me, then it should be something similar to:
Add socket option `IPV6_PKTINFO` for BSDs/Linux/Android, also `IPV6_RECVPKTINFO` for DragonFlyBSD |
Co-authored-by: SteveLauC <[email protected]>
Co-authored-by: SteveLauC <[email protected]>
SteveLauC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
IPV6_PKTINFOwas missing fromsockoptso I added it and the documentation forIPV6_RECVPKTINFOincorrectly said it was enabling the flag forIPV6_PKTINFOso I corrected that.