Skip to content

Nuke deprecated Errno flags #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2022
Merged

Nuke deprecated Errno flags #1860

merged 1 commit into from
Nov 12, 2022

Conversation

@SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Nov 12, 2022

@rtzoeller It's been quite a few releases since these have been deprecated, more bloat removal.

@rtzoeller rtzoeller mentioned this pull request Nov 12, 2022
Merged
@rtzoeller
Copy link
Collaborator

rtzoeller commented Nov 12, 2022

@SUPERCILEX can you add a note to the Removed section of the changelog?

Something like

### Removed

- Removed deprecated error constants and conversions.
  ([#1860](https://github.com/nix-rust/nix/pull/1860))

@SUPERCILEX
Nuke deprecated Errno flags
9374e60 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented Nov 12, 2022

Done!

rtzoeller
rtzoeller approved these changes Nov 12, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 12, 2022

Build succeeded:

@bors bors bot merged commit fbebb21 into nix-rust:master Nov 12, 2022
@SUPERCILEX SUPERCILEX deleted the errno branch November 12, 2022 04:42
@rchildre3 rchildre3 mentioned this pull request Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SUPERCILEX @rtzoeller