-
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add qwik example #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dfa0fcf to
d823c90
Compare
206aa11 to
eddd119
Compare
| "build.preview": "vite build --ssr src/entry.preview.tsx", | ||
| "build.types": "tsc --incremental --noEmit", | ||
| "dev": "vite --open --mode ssr", | ||
| "preview": "qwik build preview && cp -r ./dist/* ./.output/public/ && vite preview --open", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cp step is needed b/c some files are missing in the .output folder. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this extra step to have the possibility to use nitro presets 👀
|
Thanks for the PR! I have done a quick local test. Qwik vite plugin works perfectly well on it's own but adding server entry or server routes breaks both dev and prod. The requirement is, we need the Quik plugin to configure Please LMK if wanted to chat about this. |
untested because nitro fails to fallback to our server Co-authored-by: Giorgio Boa <[email protected]>
f886df1 to
44cb8b1
Compare

I added the nitro plugin on top of a minimal Qwik SSR configuration.