[FIX]: ResponseSD support for multiple b-vals #2581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
May 17, 2018
| usedefault=True, | ||
| argstr='-lmax %s', | ||
| desc=('maximum harmonic degree of response function - single value for ' | ||
| 'single-shell response, list for multi-shell response')) |
There was a problem hiding this comment.
Can this be a MultiObject?
max_sh = InputMultiObject(traits.Int, default=8, usedefault=True, argstr='-lmax %d', sep=',')I think you can keep the same doctest.
There was a problem hiding this comment.
This was my inital thought, but it looks like InputMultiPath/Object doesn't allow for defaults
In [2]: x.inputs.max_sh
Out[2]: []
|
Lists might have a different name for setting defaults. @djarecka might
know off the top of her head.
…On Thu, May 17, 2018, 16:34 Mathias Goncalves ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nipype/interfaces/mrtrix3/preprocess.py
<#2581 (comment)>:
> @@ -40,10 +40,13 @@ class ResponseSDInputSpec(MRTrix3BaseInputSpec):
argstr='%s', position=-1, desc='output CSF response text file')
in_mask = File(
exists=True, argstr='-mask %s', desc='provide initial mask image')
- max_sh = traits.Int(
- 8, usedefault=True,
- argstr='-lmax %d',
- desc='maximum harmonic degree of response function')
+ max_sh = traits.Either(
+ traits.Int(8), traits.List(traits.Int()),
+ default=8,
+ usedefault=True,
+ argstr='-lmax %s',
+ desc=('maximum harmonic degree of response function - single value for '
+ 'single-shell response, list for multi-shell response'))
This was my inital thought, but it looks like InputMultiPath/Object
doesn't allow for defaults
In [2]: x.inputs.max_sh
Out[2]: []
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2581 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8jW9zyn3jO4mgtpZb6w6Ye9vBNjtks5tzd7RgaJpZM4UDsoT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580 .
Changes proposed in this pull request
max_shinput to accept/format lists as well as int