Skip to content

Conversation

@de-sh
Copy link

@de-sh de-sh commented Jan 5, 2025

Fixes parseablehq#1058.

Description

In this branch we perform the nesting level check at every level of nesting that we traverse with generic_flattening, which is unnecessary as a single test at the starting would be enough, which is what the change proposes to do.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as ready for review January 5, 2025 09:25
@nikhilsinhaparseable nikhilsinhaparseable merged commit 131b9fe into nikhilsinhaparseable:flattening-validation Jan 5, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants