More explicit onManaged* Exceptions #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions can occurred in the onManagedDraw or onManagedUpdate methods of Entity and onUpdateSpriteBatch method of SpriteBatch: - IndexOutOfBound if a detach was done on the UI Thread; - NPE if an attach is done with a null value... These exceptions can be pretty tough to track and correct. This patch display more informations about the exact entity which can problem. It also does a NPE check in the Entity.toString(StringBuilder) method, as well as using getName instead of getSimpleName to have useful informations when using proguard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions can occurred in the onManagedDraw or onManagedUpdate methods of Entity and onUpdateSpriteBatch method of SpriteBatch:
These exceptions can be pretty tough to track and correct.
This patch display more informations about the exact entity which can problem by adding try/catch blocks to these methods and wrapping the exception with context information.
It also does a NPE check in the Entity.toString(StringBuilder) method, as well as using getName instead of getSimpleName to have useful informations when using proguard.