Re-use analyze-project from the python-actions repo #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkeryan
requested changes
Sep 25, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
I want to try aggregating job statuses
bkeryan
requested changes
Sep 25, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Let's add a job to CI.yml to summarize the checks so that the branch protection ruleset doesn't depend on OSes and Python versions.
Also, let's make sure that failing checks cause this job to not run. I tried adding typing errors and the checks still passed because analyze-project is not actually running mypy: ni/python-actions#31
…alyze-project-action
Collaborator
|
I updated the branch protection ruleset to require Run CI / Checks succeeded |
bkeryan
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Uses the newly created
analyze-projectactions from ni/python-actions repo.Why should this Pull Request be merged?
Single sources many of the static analysis checks we were duplicating in many repos.
What testing has been done?
The PR checks on this PR.