-
Notifications
You must be signed in to change notification settings - Fork 11
Rich text viewer | Implementation of markdown parser #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vivinkrishna-ni
merged 45 commits into
main
from
users/vivin/viewer-markdown-parser-implementation
Jul 25, 2023
Merged
Changes from 38 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5a348d0
Implemented markdown parser and added markdown value API for viewer c…
vivinkrishna-ni 53bc3ce
Change files
vivinkrishna-ni 590a2c8
Removed tiptap/pm and added only pm-markdown and pm-model as some pac…
vivinkrishna-ni 68b157c
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 698f22b
Resolved some of the PR comments
vivinkrishna-ni 8b955cb
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni f625d25
Resolve linting errors
vivinkrishna-ni 5db53e9
Added node polyfills to support punycode used in the markdown-it library
vivinkrishna-ni c7d4d23
Added append document fragment when setting the markdown value
vivinkrishna-ni b503590
Cleared the inner HTML and appended the rich text content to viewer c…
vivinkrishna-ni 7d1b9ee
Run npm install in the root directory
vivinkrishna-ni a713cfd
Updated UI and added storybook matrix tests
vivinkrishna-ni bb0d76a
Resolved some of the PR comments
vivinkrishna-ni 41531b7
Updated the styles for nodes in viewer component
vivinkrishna-ni 09cc91e
Renamed 'markdown' and removed `fit-to-content` attribute.
vivinkrishna-ni 4a421cf
Resolve linting errors
vivinkrishna-ni 4ee7a61
Changes for resolving some of the comments
vivinkrishna-ni 0704f4c
Resolving lint error
vivinkrishna-ni 18061a9
Moved the type/markdown-it to dependencies from dev
vivinkrishna-ni 68298ce
Fixed issue in setting the margin style for list paragraphs
vivinkrishna-ni 035e583
Resolve linting error
vivinkrishna-ni e5cff56
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni b579ce0
Updated the name of the viewer function and removed id
vivinkrishna-ni d4d9fe1
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni a549149
Test commit to check whether methods work on Safari browsers
vivinkrishna-ni 8533518
Revoked the previous test commit
vivinkrishna-ni 1246017
Resolved some of the PR comments
vivinkrishna-ni 9a0b11e
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 5816a66
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni edbec0a
Added aftereach in the unit test cases
vivinkrishna-ni ff08921
Added the null assertion for markdown observable
vivinkrishna-ni 770a349
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni c520616
Updated and added few test cases for markdown strings. Updated the sp…
vivinkrishna-ni 5757830
Updated few minor changes.
vivinkrishna-ni 351cd1e
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 8eff4f6
Updated package-lock.json
vivinkrishna-ni a29a7f9
Changes for resolving some comments
vivinkrishna-ni 14ab812
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 426ee92
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 0b22333
Enabled normalize setting back and updated test cases accordingly.
vivinkrishna-ni 9927fc8
Merge branch 'users/vivin/viewer-markdown-parser-implementation' of h…
vivinkrishna-ni 71f520f
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni 247c156
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni e3d9d40
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni bc69fb9
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-99393253-07d1-4ec4-902b-41680bddd36e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
vivinkrishna-ni marked this conversation as resolved.
Show resolved
Hide resolved
rajsite marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "type": "patch", | ||
vivinkrishna-ni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "comment": "Implementation of markdown parser for converting markdown input to rich text content in the viewer", | ||
vivinkrishna-ni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "packageName": "@ni/nimble-components", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } | ||
jattasNI marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.