Update to latest ni-apis #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .proto files to the latest version from the ni-apis repository and regenerates the corresponding gRPC stubs. The changes primarily involve renaming specific fields across multiple message types to use more concise naming conventions, such as changing compound field names like operator_name to simply name.
- Updated subproject commit for third_party/ni-apis
- Renamed fields in metadata and data store proto files to use shorter, more consistent naming conventions
- Regenerated Python stub files with updated field names and serialization offsets
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/ni-apis | Updated subproject commit to latest version |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_pb2/init.pyi | Updated type stub with renamed fields from compound names to simple 'name' |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_pb2/init.py | Updated generated Python code with renamed fields and adjusted serialization offsets |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_service_pb2/init.pyi | Updated type stub with renamed fields and added notes field |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_service_pb2/init.py | Updated generated Python code with renamed fields and adjusted serialization offsets |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_pb2/init.pyi | Updated type stub with renamed fields from compound names to simple names |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_pb2/init.py | Updated generated Python code with renamed fields and adjusted serialization offsets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jfriedri-ni
approved these changes
Oct 30, 2025
bkeryan
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Stay up-to-date with the .proto files.
What testing has been done?
PR