Add XYData conversion methods #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
Contributor
mjohanse-emr
commented
Oct 9, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/xydata_conversion.py
Outdated
Show resolved
Hide resolved
csjall
approved these changes
Oct 10, 2025
jfriedri-ni
approved these changes
Oct 10, 2025
packages/ni.protobuf.types/tests/unit/test_xydata_conversion.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Oct 10, 2025
Signed-off-by: Michael Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
XYDatapython objects to/from protobuf messages.nitypesthat hasXYDataimplemented.Request for Comment
For XYData objects that aren't of type
np.float64, I'm just converting the numeric values tofloatduring the_to_protobufmethod. The alternative is to raise an error in this case. I think converting to float is more user friendly, but I can see a case for throwing an error.Why should this Pull Request be merged?
Implements part of AB#3266236
To allow clients of
ni.protobuf.typesto easily convert to/from protobuf messages.What testing has been done?
Unit tests, mypy, pyright, styleguide.