TECHDOCS-1157 add instructions examples #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kplotnik
requested changes
May 12, 2022
README.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Maps API for JavaScript | |||
|
|
|||
| This repository holds a series of JavaScript based examples using the **HERE Maps API for JavaScript**. More information about the API can be found on [developer.here.com](https://developer.here.com/develop/javascript-api) under the JavaScript APIs section. | |||
| Download all files in the GitHub folder linked to the "Fork on GitHub" button on the top of the example page. Additionally, download the **test-credentials.js** file, the **template.css** file and the **meta.json** file from the folder **maps-api-for-javascript-examples** and place it in a folder above your folder in which you placed the example. | |||
There was a problem hiding this comment.
This Readme is available on gihub only. Why do we send the user back to developer.here.com? Besides, I presume, that we talk to developers here who understand what is Git - so I'd expect to see here the instructions in the spirit clone the repository, host it on your local server (or npx serve) and replace credentials
|
Looks good to me, thank you. |
|
@kplotnik unfortunately I don't have rights to merge to the master repo. Can you merge my commit from my fork to the master repo? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.