Skip to content

Changed min width of parent grid to be smaller #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2025
Merged

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Jul 29, 2025

Proposed changes

Better support mobile devices by making min width zero.

Before:
Screenshot 2025-08-18 at 12 56 21 PM

After:
Screenshot 2025-08-18 at 12 56 09 PM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Jul 29, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner July 29, 2025 16:37
@lamATnginx lamATnginx added the enhancement New feature or request label Jul 29, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/338/

@danielledeleo
Copy link
Contributor

Screenshot 2025-07-29 at 2 13 20 PM

Think we can tack on general padding changes (mobile only) onto this PR? On mobile we can reclaim that extra gutter space. Though it's probably easier to remove the overhanging callouts and shrink the gutter.

Also looks like the breadcrumbs are breaking too early.

@lamATnginx lamATnginx merged commit 0507e25 into mainframe Aug 19, 2025
4 checks passed
@lamATnginx lamATnginx deleted the grid-min-width branch August 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants