This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Logging #4
Merged
Logging #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekobon
suggested changes
Jun 21, 2021
| } | ||
| 'controller': { | ||
| 'healthStatus': True, | ||
| 'nginxplus': False, |
Collaborator
There was a problem hiding this comment.
nginxplus is defined below, so it doesn't need to be redefined here.
| } | ||
| }, | ||
| 'service': { | ||
| 'annotations': { |
Collaborator
There was a problem hiding this comment.
Is there a way to conditionally include the elastic configuration, so that it is only present when we also are using the ELK extras?
Contributor
Author
There was a problem hiding this comment.
Yes; I figured we would do this as part of the overall deployment manifest yaml that is implied in Issue #3
Collaborator
|
Also, be sure that test.py runs and all tests pass. |
dekobon
approved these changes
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds a log store (elasticsearch) and a log agent (filebeat) and configures them to work with the
NGINX KIC controller. Additionally, the elasticsearch deployment includes a kibana instance for visualization.
Documentation has been updated to explain the deployment options and process, as well as provide instructions
on accessing the kibana dashboard. Additionally, pre-built kibana elements have been provided for import.
Checklist
Before creating a PR, run through this checklist and mark each as complete.