Skip to content

Add patches to helm chart spec #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Add patches to helm chart spec #3773

merged 2 commits into from
Aug 21, 2025

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want a way to specify patches for service , deployment and daemonSet in the helm chart spec

Solution: Added patches field in helm chart spec

Testing:Manual testing

  1. Patches when applied for service deployment and daemonSet are translated to Nginx deployment/service
  2. When patches are not specified, they are not rendered in NginxProxy

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3761

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add patches to helm chart spec for NGINX service, deployment and daemonSet

@salonichf5 salonichf5 requested a review from a team as a code owner August 21, 2025 15:44
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels Aug 21, 2025
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.00%. Comparing base (8f6d24b) to head (7769e69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
+ Coverage   86.99%   87.00%   +0.01%     
==========================================
  Files         128      128              
  Lines       16404    16404              
  Branches       62       62              
==========================================
+ Hits        14270    14272       +2     
+ Misses       1958     1957       -1     
+ Partials      176      175       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 enabled auto-merge (squash) August 21, 2025 18:22
@salonichf5 salonichf5 merged commit 4690674 into main Aug 21, 2025
50 of 51 checks passed
@salonichf5 salonichf5 deleted the chore/patches branch August 21, 2025 20:37
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 21, 2025
salonichf5 added a commit that referenced this pull request Aug 21, 2025
Problem: Users want a way to specify patches for service , deployment and daemonSet in the helm chart spec

Solution: Added patches field in helm chart spec
@salonichf5 salonichf5 mentioned this pull request Aug 21, 2025
6 tasks
salonichf5 added a commit that referenced this pull request Aug 21, 2025
Problem: Users want a way to specify patches for service , deployment and daemonSet in the helm chart spec

Solution: Added patches field in helm chart spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support resource patch config in Helm chart
3 participants