-
Notifications
You must be signed in to change notification settings - Fork 133
Add local nginx dev env #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add local nginx dev env #3752
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
==========================================
+ Coverage 86.85% 86.88% +0.03%
==========================================
Files 128 128
Lines 16187 16187
Branches 62 62
==========================================
+ Hits 14059 14064 +5
+ Misses 1954 1950 -4
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a local development environment for testing nginx configurations in Kubernetes. It provides a simple setup with nginx proxying to an echo server backend for easier local development and testing.
- Creates kubernetes deployment manifests for nginx proxy and echo server
- Adds nginx configuration with health check and proxy setup
- Provides a Makefile with convenient commands for deployment, testing, and cleanup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
dev/nginx/nginx.yaml | Kubernetes manifests for nginx proxy deployment, echo server deployment, and echo service |
dev/nginx/nginx.conf | Basic nginx configuration with upstream backend and proxy rules |
dev/nginx/README.md | Documentation explaining how to use the development environment |
dev/nginx/Makefile | Automation commands for deploying, testing, and managing the development setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
45de805
to
018c2be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just a couple of documentation comments :)
I love how you are chatting back with the CoPilot 😁
Co-authored-by: Saloni Choudhary <[email protected]>
Co-authored-by: Saloni Choudhary <[email protected]>
Proposed changes
Problem: Developers found it difficult and annoying to test local nginx configuration..
Solution: I created a solution that creates a simple nginx pod with conf in a ConfigMap and a Makefile for easy use.
Testing: Manually tested
Closes #1502
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.