Skip to content

Add local nginx dev env #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add local nginx dev env #3752

wants to merge 3 commits into from

Conversation

sarthyparty
Copy link
Contributor

@sarthyparty sarthyparty commented Aug 18, 2025

Proposed changes

Problem: Developers found it difficult and annoying to test local nginx configuration..

Solution: I created a solution that creates a simple nginx pod with conf in a ConfigMap and a Makefile for easy use.

Testing: Manually tested

Closes #1502

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sarthyparty sarthyparty requested a review from a team as a code owner August 18, 2025 19:27
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 18, 2025
@sarthyparty sarthyparty requested a review from Copilot August 18, 2025 19:27
Copilot

This comment was marked as outdated.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.88%. Comparing base (235a4b2) to head (40abda5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
+ Coverage   86.85%   86.88%   +0.03%     
==========================================
  Files         128      128              
  Lines       16187    16187              
  Branches       62       62              
==========================================
+ Hits        14059    14064       +5     
+ Misses       1954     1950       -4     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthyparty sarthyparty requested a review from Copilot August 18, 2025 19:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a local development environment for testing nginx configurations in Kubernetes. It provides a simple setup with nginx proxying to an echo server backend for easier local development and testing.

  • Creates kubernetes deployment manifests for nginx proxy and echo server
  • Adds nginx configuration with health check and proxy setup
  • Provides a Makefile with convenient commands for deployment, testing, and cleanup

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
dev/nginx/nginx.yaml Kubernetes manifests for nginx proxy deployment, echo server deployment, and echo service
dev/nginx/nginx.conf Basic nginx configuration with upstream backend and proxy rules
dev/nginx/README.md Documentation explaining how to use the development environment
dev/nginx/Makefile Automation commands for deploying, testing, and managing the development setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just a couple of documentation comments :)

I love how you are chatting back with the CoPilot 😁

sarthyparty and others added 2 commits August 18, 2025 14:41
Co-authored-by: Saloni Choudhary <[email protected]>
Co-authored-by: Saloni Choudhary <[email protected]>
@sarthyparty sarthyparty requested a review from salonichf5 August 18, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Add NGINX OSS development environment for testing
3 participants