Skip to content

Add cel tests for upstreamsettingspolicy #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sarthyparty
Copy link
Contributor

Proposed changes

Problem: There were no CEL tests for UpstreamSettingsPolicy

Solution: I added it

Testing: Describe any testing that you did.
Closes #3672

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sarthyparty sarthyparty requested a review from a team as a code owner August 14, 2025 23:28
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.88%. Comparing base (235a4b2) to head (6fa3824).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
+ Coverage   86.85%   86.88%   +0.03%     
==========================================
  Files         128      128              
  Lines       16187    16187              
  Branches       62       62              
==========================================
+ Hits        14059    14064       +5     
+ Misses       1954     1950       -4     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthyparty sarthyparty requested a review from shaun-nx August 15, 2025 17:11
@sarthyparty sarthyparty force-pushed the tests/cel-upstreamsettingspolicy branch from 51b7ad2 to 27429bd Compare August 15, 2025 17:12
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Great job @sarthyparty! 🎉

@sarthyparty sarthyparty requested a review from salonichf5 August 18, 2025 18:39
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sarthyparty sarthyparty enabled auto-merge (squash) August 18, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Add CEL test for UpstreamSettingsPolicy CRD
3 participants