-
Notifications
You must be signed in to change notification settings - Fork 133
Add cel tests for upstreamsettingspolicy #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
+ Coverage 86.85% 86.88% +0.03%
==========================================
Files 128 128
Lines 16187 16187
Branches 62 62
==========================================
+ Hits 14059 14064 +5
+ Misses 1954 1950 -4
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51b7ad2
to
27429bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Great job @sarthyparty! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
Problem: There were no CEL tests for UpstreamSettingsPolicy
Solution: I added it
Testing: Describe any testing that you did.
Closes #3672
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.