Use a common k8s API fake reader

[pleshakov]

#1551 telemetry package starting using https://github.com/nginxinc/nginx-gateway-fabric/blob/dca4d6432ee43403c3b815186b9b8585a2ca8a48/internal/framework/events/eventsfakes/fake_reader.go#L13 which is generated in https://github.com/nginxinc/nginx-gateway-fabric/blob/dca4d6432ee43403c3b815186b9b8585a2ca8a48/internal/framework/events/first_eventbatch_preparer.go#L28 , which creates unnecessary dependency between modules

Acceptance criteria:

• Remove that unnecessary dependency

Came from #1551 (comment)

[github-actions]

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[miledxz]

Hi @mpstefan feel free to assign me !

@pleshakov could you please explain a little bit more in details what is main idea,
from my understanding we want to remove usage of FakeReader generated by counterfeiter, from tests of telemetry pkg ?
As stated here: #1551 (comment)

But what would replace it then ? Feel free to correct me as I'm not sure what is main idea.

Thank you in advance !

[kate-osborn]

Hi @mpstefan feel free to assign me !

@pleshakov could you please explain a little bit more in details what is main idea, from my understanding we want to remove usage of FakeReader generated by counterfeiter, from tests of telemetry pkg ? As stated here: #1551 (comment)

But what would replace it then ? Feel free to correct me as I'm not sure what is main idea.

Thank you in advance !

Hi @miledxz, the idea is to move the FakeReader mock out of the eventfakes package into a common package -- maybe named kubernetesfakes. This package can live in /internal/framework/. All of the users of the FakeReader will now depend on kubernetesfakes instead of eventfakes.

[miledxz]

Hi @kate-osborn thank you for fast reply, so what I can do is just create another directory named kubernetesfakes and move FakeReader mock there, and then update import paths as required,

just wanted to clarify so we are on the same page, thanks !

[kate-osborn]

Hi @kate-osborn thank you for fast reply, so what I can do is just create another directory named kubernetesfakes and move FakeReader mock there, and then update import paths as required,

just wanted to clarify so we are on the same page, thanks !

Actually, since the mock is generated you will have to do a few other things:

• create a kubernetes directory in /internal/framework/
• delete the eventfakes directory
• move the Reader interface to the kubernetes directory. Add //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 -generate above the interface definition
• run make generate from the root of the repo
• update import statements

[miledxz]

@kate-osborn thank you for all the explanations and your time, will do !