Skip to content

Conversation

bavshin-f5
Copy link
Member

This release fixes a linking issue with BoringSSL and a build error on NetBSD 10. It also bumps several dependencies to the current versions, cleaning up our dependency tree.

Enable CI tests for BoringSSL, and statically linked AWS-LC.

With cargo tree --prefix=none --no-dedupe --format='{p}' | sort -u | wc -l,
Before: 85
After: 76

This release fixes a linking issue with BoringSSL and a build error on
NetBSD 10. It also bumps several dependencies to the current versions,
cleaning up our dependency tree.
"-lstdc++" is insufficient for static linking on Debian and Ubuntu.
Use latest tags instead of main for both libraries.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates rust-openssl to version 0.10.74 to fix BoringSSL linking issues and NetBSD 10 build errors while reducing dependencies from 85 to 76. It also enables CI testing for BoringSSL variants and refactors AWS-LC configuration.

  • Updated openssl and openssl-sys dependencies to latest versions
  • Added CI test coverage for BoringSSL and statically linked AWS-LC configurations
  • Fixed BoringSSL build configuration to use C++ compiler properly

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
Cargo.toml Updated openssl and openssl-sys dependency versions
build/build-boringssl.mk Modified NGINX configuration for BoringSSL builds
build/build-boringssl-static.mk Modified NGINX configuration for static BoringSSL builds
.github/workflows/ci.yaml Added BoringSSL CI builds and restructured AWS-LC configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bavshin-f5 bavshin-f5 merged commit fa3acfa into nginx:main Oct 20, 2025
20 checks passed
@bavshin-f5 bavshin-f5 deleted the rust-openssl branch October 20, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants