add globalConfigurationCustomName parameter #8142

mohamadaldawamnah · 2025-08-14T16:40:18Z

Proposed changes

Added support for globalConfiguration CustomName parameter as submitted by community member @frantsao

PR: #6679

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Add globalConfigurationCustomName parameter to controller configuration in helm chart (#6679)

for more information, see https://pre-commit.ci

…customName

for more information, see https://pre-commit.ci

…sue-6679

Extend globalConfiguration customName functionality when gc create true (#6679)

Fix documentation in values.yaml (#6679)

…ommunity member , added some changes

github-actions · 2025-08-14T16:49:24Z

Package Report

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx, 1.29.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx, 1.29.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-attack-signatures, 2025.08.07-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-threat-campaigns, 2025.08.11-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-module-plus, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-plugin, 6.20.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-attack-signatures, 2025.08.07-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-threat-campaigns, 2025.08.11-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx, 1.29.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx, 1.29.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 2.42.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-attack-signatures, 2025.08.07-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-threat-campaigns, 2025.08.11-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 2.42.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-module-plus, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-plugin, 6.20.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx, 1.29.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx, 1.29.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-attack-signatures, 2025.08.07-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-threat-campaigns, 2025.08.11-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-module-plus, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-plugin, 6.20.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-attack-signatures, 2025.08.07-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-threat-campaigns, 2025.08.11-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-module-plus, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-plugin, 6.20.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-attack-signatures, 2025.08.07-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-threat-campaigns, 2025.08.11-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64

vepatel · 2025-08-15T08:57:52Z

Update: https://github.com/nginx/kubernetes-ingress/tree/feature/global-config-custom-name-validation/charts/tests/testdata and https://github.com/nginx/kubernetes-ingress/blob/feature/global-config-custom-name-validation/charts/tests/helmunit_test.go with new test for custom name.

can use:

codecov · 2025-08-15T13:54:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.11%. Comparing base (78b11d4) to head (30e28ce).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8142      +/-   ##
==========================================
+ Coverage   53.08%   53.11%   +0.02%     
==========================================
  Files          90       90              
  Lines       21778    21778              
==========================================
+ Hits        11561    11567       +6     
+ Misses       9740     9736       -4     
+ Partials      477      475       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

Copilot

Pull Request Overview

This PR adds support for a globalConfiguration.customName parameter that allows users to specify a custom namespace and name for the GlobalConfiguration custom resource instead of using the default generated name.

Adds customName parameter to values.yaml with validation logic
Updates Helm templates to use the custom name when provided
Includes comprehensive test coverage for valid and invalid custom name formats

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
charts/nginx-ingress/values.yaml	Adds the new `customName` parameter with documentation
charts/nginx-ingress/values.schema.json	Defines JSON schema for the new `customName` field
charts/nginx-ingress/templates/_helpers.tpl	Implements validation and parsing logic for custom names
charts/nginx-ingress/templates/controller-globalconfiguration.yaml	Updates template to use custom name when provided
charts/tests/helmunit_test.go	Adds test cases for valid and invalid custom name scenarios
charts/tests/testdata/*.yaml	Test data files for various custom name scenarios
charts/tests/snapshots/helmunit_test.snap	Expected test outputs for the new functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-18T13:50:41Z

charts/nginx-ingress/templates/_helpers.tpl

+{{- if .Values.controller.globalConfiguration.customName }}
+{{- $parts := splitList "/" .Values.controller.globalConfiguration.customName }}
+{{- if ne (len $parts) 2 }}
+{{- fail "globalConfiguration.customName must contain exactly one '/' separator in namespace/name format (e.g., \"my-namespace/my-global-config\")" }}


The error message is inconsistent with the actual validation logic in the test cases. The test expects 'globalConfiguration.customName must contain exactly one '/' separator' but this message includes additional format details.

Suggested change

{{- fail "globalConfiguration.customName must contain exactly one '/' separator in namespace/name format (e.g., \"my-namespace/my-global-config\")" }}

{{- fail "globalConfiguration.customName must contain exactly one '/' separator" }}

Copilot · 2025-08-18T13:50:41Z

charts/nginx-ingress/templates/_helpers.tpl

+{{- fail "globalConfiguration.customName must contain exactly one '/' separator in namespace/name format (e.g., \"my-namespace/my-global-config\")" }}
+{{- end }}
+{{- if or (eq (index $parts 0) "") (eq (index $parts 1) "") }}
+{{- fail "globalConfiguration.customName namespace and name parts cannot be empty (e.g., \"my-namespace/my-global-config\")" }}


The error message is inconsistent with the test expectation. The test expects 'globalConfiguration.customName namespace and name parts cannot be empty' but this message includes additional format details.

Suggested change

{{- fail "globalConfiguration.customName namespace and name parts cannot be empty (e.g., \"my-namespace/my-global-config\")" }}

{{- fail "globalConfiguration.customName namespace and name parts cannot be empty" }}

frantsao and others added 28 commits October 17, 2024 17:52

Helm: add globalConfigurationCustomName parameter

812e7ef

Add globalConfigurationCustomName parameter to controller configuration in helm chart (#6679)

Merge branch 'main' into issue-6679

24720e9

[pre-commit.ci] auto fixes from pre-commit.com hooks

1db8f4a

for more information, see https://pre-commit.ci

Remove unneeded comment in values.yaml

548ac11

Merge branch 'main' into issue-6679

db5c8f4

Merge branch 'main' into issue-6679

e09ada1

Merge branch 'main' into issue-6679

8d64188

Merge branch 'main' into issue-6679

4f4b1db

Merge branch 'main' into issue-6679

5a57015

Merge branch 'main' into issue-6679

ee5c86b

moved globalConfigurationCustomName parameter to globalConfiguration.…

610f49e

…customName

[pre-commit.ci] auto fixes from pre-commit.com hooks

0823d8d

for more information, see https://pre-commit.ci

Fix values.schema.json format

3969d8b

Merge remote-tracking branch 'refs/remotes/origin/issue-6679' into is…

151ef1b

…sue-6679

Merge branch 'main' into issue-6679

d7d59aa

Merge branch 'main' into issue-6679

ae76aea

Helm: add globalConfigurationCustomName parameter

8490da9

Extend globalConfiguration customName functionality when gc create true (#6679)

Helm: add globalConfigurationCustomName parameter

f8681b7

Fix documentation in values.yaml (#6679)

Merge branch 'main' into issue-6679

40f944b

Merge branch 'main' into issue-6679

b952899

Merge branch 'main' into issue-6679

d28a769

Merge branch 'main' into issue-6679

5b1c592

Merge branch 'main' into issue-6679

8ef8c23

Merge branch 'main' into issue-6679

56b971d

Merge branch 'main' into issue-6679

0373dee

Merge branch 'main' into issue-6679

8ef2afa

Merge branch 'main' into issue-6679

1674a9b

adding validation and testing for global conifugration submitted by c…

0f32e92

…ommunity member , added some changes

mohamadaldawamnah requested a review from a team as a code owner August 14, 2025 16:40

github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 14, 2025

vepatel linked an issue Aug 14, 2025 that may be closed by this pull request

GlobalConfiguration custom name in helm chart #6679

Open

danielnginx requested a review from Copilot August 14, 2025 16:53

This comment was marked as outdated.

Sign in to view

add global configuration customName tests

fec51dc

github-actions bot added the go Pull requests that update Go code label Aug 15, 2025

add snapshot file for testing customnames

e11051e

mohamadaldawamnah and others added 5 commits August 15, 2025 15:59

Update charts/nginx-ingress/templates/_helpers.tpl

e010269

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

Update charts/nginx-ingress/templates/_helpers.tpl

cdcd122

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

resolving issues mentioned by github copilot

8503642

resolving issues mentioned by github copilot

c323791

fixing linting format

30e28ce

mohamadaldawamnah requested a review from Copilot August 15, 2025 16:01

This comment was marked as outdated.

Sign in to view

changing If statment and making sure it can be reached

0715d0b

mohamadaldawamnah requested a review from Copilot August 15, 2025 16:22

This comment was marked as outdated.

Sign in to view

mohamadaldawamnah and others added 3 commits August 15, 2025 17:27

Update charts/nginx-ingress/templates/_helpers.tpl

33ec452

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

Update charts/nginx-ingress/templates/_helpers.tpl

69d1fb6

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

fixing copilot mentioned error

6a8b464

mohamadaldawamnah requested a review from Copilot August 15, 2025 16:34

This comment was marked as outdated.

Sign in to view

mohamadaldawamnah and others added 2 commits August 15, 2025 17:43

Update charts/nginx-ingress/templates/_helpers.tpl

1f228b1

Co-authored-by: Copilot <[email protected]> Signed-off-by: mohamad_al <[email protected]>

fixing copilot mentioned error

4729417

mohamadaldawamnah requested a review from Copilot August 15, 2025 16:57

This comment was marked as outdated.

Sign in to view

danielnginx requested a review from Copilot August 18, 2025 13:44

Copilot AI reviewed Aug 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add globalConfigurationCustomName parameter #8142

add globalConfigurationCustomName parameter #8142

mohamadaldawamnah commented Aug 14, 2025 •

edited by vepatel

Loading

Uh oh!

github-actions bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

vepatel commented Aug 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 18, 2025

Uh oh!

Copilot AI Aug 18, 2025

Uh oh!

Uh oh!

	{{- fail "globalConfiguration.customName must contain exactly one '/' separator in namespace/name format (e.g., \"my-namespace/my-global-config\")" }}
	{{- fail "globalConfiguration.customName must contain exactly one '/' separator" }}

add globalConfigurationCustomName parameter #8142

Are you sure you want to change the base?

add globalConfigurationCustomName parameter #8142

Conversation

mohamadaldawamnah commented Aug 14, 2025 • edited by vepatel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Report

Uh oh!

This comment was marked as outdated.

Uh oh!

vepatel commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mohamadaldawamnah commented Aug 14, 2025 •

edited by vepatel

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading

vepatel commented Aug 15, 2025 •

edited

Loading

codecov bot commented Aug 15, 2025 •

edited

Loading